Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-600 Support the max major/minor/patch version is MaxInt16 #355

Merged
merged 6 commits into from
May 31, 2018

Conversation

little-cui
Copy link
Member

(cherry picked from commit a3f28c4)

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@little-cui little-cui self-assigned this May 23, 2018
@codecov-io
Copy link

codecov-io commented May 23, 2018

Codecov Report

Merging #355 into master will increase coverage by 2.12%.
The diff coverage is 94.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   69.33%   71.46%   +2.12%     
==========================================
  Files          18       25       +7     
  Lines        3437     3690     +253     
==========================================
+ Hits         2383     2637     +254     
+ Misses        885      884       -1     
  Partials      169      169
Impacted Files Coverage Δ
server/service/service.go 100% <ø> (ø)
server/service/rule.go 74.52% <100%> (-2.3%) ⬇️
server/service/dependency_validator.go 100% <100%> (ø)
server/service/instance.go 68.37% <100%> (ø)
server/service/util/versionrule.go 100% <100%> (ø) ⬆️
server/service/rule_validator.go 100% <100%> (ø)
server/service/instance_validator.go 100% <100%> (ø)
server/service/schema_validator.go 100% <100%> (ø)
server/service/tag_validator.go 100% <100%> (ø)
server/service/tag.go 75.43% <100%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87ea66...4c503c3. Read the comment docs.

@coveralls
Copy link

coveralls commented May 23, 2018

Coverage Status

Coverage increased (+1.7%) to 74.631% when pulling 4c503c3 on little-cui:master into b87ea66 on apache:master.

@wujimin
Copy link

wujimin commented May 23, 2018

why limit to 999?
just short max is OK ?

@little-cui little-cui changed the title SCB-600 Support the max major/minor/patch version is '999' SCB-600 Support the max major/minor/patch version is MaxInt16 May 24, 2018
@little-cui
Copy link
Member Author

@wujimin OK, that is a good suggestion

@little-cui little-cui force-pushed the master branch 5 times, most recently from 9239ddb to 1fc6d84 Compare May 30, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants