Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-862 Using different environment variables in image #427

Merged
merged 1 commit into from Aug 23, 2018

Conversation

little-cui
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

#424

@little-cui little-cui self-assigned this Aug 22, 2018
@little-cui little-cui changed the title Docker hub 中的service center 镜像说明需要优化 Using different environment variables in image Aug 22, 2018
@little-cui little-cui changed the title Using different environment variables in image SCB-862 Using different environment variables in image Aug 22, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 76.177% when pulling b4c1199 on little-cui:script into 9f55487 on apache:master.

@codecov-io
Copy link

Codecov Report

Merging #427 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files         128      128           
  Lines        9978     9978           
=======================================
  Hits         7281     7281           
  Misses       2221     2221           
  Partials      476      476
Impacted Files Coverage Δ
pkg/util/util.go 61.11% <0%> (-1.39%) ⬇️
server/broker/util.go 53.2% <0%> (-0.27%) ⬇️
server/govern/service.go 73.66% <0%> (+0.33%) ⬆️
server/service/notification/websocket.go 84.51% <0%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f55487...b4c1199. Read the comment docs.

@little-cui little-cui merged commit ed50817 into apache:master Aug 23, 2018
@little-cui little-cui deleted the script branch August 23, 2018 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants