Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-850 Support discover instances from kubernetes cluster #433

Merged
merged 7 commits into from Sep 6, 2018

Conversation

little-cui
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@little-cui
Copy link
Member Author

#394

@codecov-io
Copy link

codecov-io commented Sep 2, 2018

Codecov Report

Merging #433 into master will decrease coverage by 0.02%.
The diff coverage is 70.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   69.29%   69.27%   -0.03%     
==========================================
  Files         140      145       +5     
  Lines       10826    11023     +197     
==========================================
+ Hits         7502     7636     +134     
+ Misses       2845     2814      -31     
- Partials      479      573      +94
Impacted Files Coverage Δ
pkg/log/zap.go 86.91% <ø> (ø) ⬆️
server/infra/discovery/cache_kv.go 95.6% <ø> (ø)
pkg/log/log_go19.go 100% <ø> (ø) ⬆️
...ver/plugin/infra/discovery/etcd/listwatch_inner.go 100% <ø> (ø)
server/plugin/plugin.go 75% <0%> (-1.42%) ⬇️
server/core/core.go 0% <0%> (ø) ⬆️
server/core/config.go 0% <0%> (ø) ⬆️
server/core/microservice.go 71.23% <0%> (-4.77%) ⬇️
server/plugin/infra/quota/buildin/common.go 22.85% <0%> (ø) ⬆️
pkg/gopool/goroutines.go 100% <100%> (ø) ⬆️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f97881...4f0e314. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 2, 2018

Coverage Status

Coverage increased (+0.4%) to 72.489% when pulling 4f0e314 on little-cui:master into 7f97881 on apache:master.

@tianxiaoliang
Copy link
Contributor

ok

@asifdxtreme
Copy link
Member

@little-cui please update the License files for release

Copy link
Member

@asifdxtreme asifdxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the License file for new dependencies added

@little-cui
Copy link
Member Author

Hi, all. I have finish this issue now, you can view the integration/k8s/README.md for more details

@little-cui little-cui merged commit 4db2f29 into apache:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants