New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCB-850 Support discover instances from kubernetes cluster #433
Conversation
45f725e
to
1072332
Compare
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
- Coverage 69.29% 69.27% -0.03%
==========================================
Files 140 145 +5
Lines 10826 11023 +197
==========================================
+ Hits 7502 7636 +134
+ Misses 2845 2814 -31
- Partials 479 573 +94
Continue to review full report at Codecov.
|
ok |
@little-cui please update the License files for release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the License file for new dependencies added
21b9219
to
c9d7a69
Compare
Hi, all. I have finish this issue now, you can view the integration/k8s/README.md for more details |
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles
, where you replaceSCB-XXX
with the appropriate JIRA issue.go build
go test
go fmt
go vet
to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.