Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-927 The latest Lager is not compatible #445

Merged
merged 2 commits into from Sep 25, 2018

Conversation

little-cui
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@little-cui little-cui self-assigned this Sep 20, 2018
@little-cui
Copy link
Member Author

Plz do not merge this now, there some works is pending

@codecov-io
Copy link

codecov-io commented Sep 20, 2018

Codecov Report

Merging #445 into master will decrease coverage by 0.04%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #445      +/-   ##
=========================================
- Coverage   59.74%   59.7%   -0.05%     
=========================================
  Files         149     149              
  Lines       13167   13174       +7     
=========================================
- Hits         7867    7865       -2     
- Misses       4729    4737       +8     
- Partials      571     572       +1
Impacted Files Coverage Δ
server/service/util/dependency_util.go 51.21% <100%> (+0.29%) ⬆️
pkg/log/logger.go 95.74% <100%> (ø) ⬆️
pkg/log/zap.go 89.42% <66.66%> (+2.5%) ⬆️
server/service/notification/listwatcher.go 69.01% <0%> (-9.86%) ⬇️
pkg/etcdsync/mutex.go 61.29% <0%> (-5.38%) ⬇️
server/service/notification/websocket.go 83.87% <0%> (-0.65%) ⬇️
server/service/tag.go 68.26% <0%> (-0.06%) ⬇️
server/service/microservice.go 71.4% <0%> (-0.06%) ⬇️
server/service/instance.go 68.33% <0%> (+0.12%) ⬆️
server/service/rule.go 70.68% <0%> (+0.52%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3404f76...559a22f. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 20, 2018

Coverage Status

Coverage decreased (-0.08%) to 62.176% when pulling 559a22f on little-cui:lager into 3404f76 on apache:master.

(cherry picked from commit 4af5629)
Copy link
Member

@asifdxtreme asifdxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@little-cui
Copy link
Member Author

@asifdxtreme DONE!

@little-cui little-cui merged commit 95013d4 into apache:master Sep 25, 2018
@little-cui little-cui deleted the lager branch September 25, 2018 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants