New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCB-927 The latest Lager is not compatible #445
Conversation
Plz do not merge this now, there some works is pending |
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
=========================================
- Coverage 59.74% 59.7% -0.05%
=========================================
Files 149 149
Lines 13167 13174 +7
=========================================
- Hits 7867 7865 -2
- Misses 4729 4737 +8
- Partials 571 572 +1
Continue to review full report at Codecov.
|
4d9dc62
to
4562152
Compare
(cherry picked from commit 4af5629)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove istio/glog license from https://github.com/apache/incubator-servicecomb-service-center/blob/master/scripts/release/LICENSE#L245
@asifdxtreme DONE! |
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles
, where you replaceSCB-XXX
with the appropriate JIRA issue.go build
go test
go fmt
go vet
to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.