Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-972 Using Sha1 signature key as UUID of micro service #460

Merged
merged 2 commits into from Oct 23, 2018

Conversation

little-cui
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@little-cui little-cui self-assigned this Oct 22, 2018
@coveralls
Copy link

coveralls commented Oct 22, 2018

Coverage Status

Coverage decreased (-0.2%) to 62.554% when pulling 16e3882 on little-cui:master into 5a54da2 on apache:master.

@codecov-io
Copy link

Codecov Report

Merging #460 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   60.18%   60.16%   -0.02%     
==========================================
  Files         156      156              
  Lines       13414    13415       +1     
==========================================
- Hits         8073     8071       -2     
- Misses       4762     4765       +3     
  Partials      579      579
Impacted Files Coverage Δ
server/service/microservice.go 71.45% <100%> (+0.05%) ⬆️
server/service/instance.go 68.53% <100%> (+0.19%) ⬆️
pkg/etcdsync/mutex.go 61.29% <0%> (-5.38%) ⬇️
server/service/util/tag_util.go 61.53% <0%> (-3.85%) ⬇️
pkg/util/tree.go 81.25% <0%> (-3.13%) ⬇️
server/service/notification/websocket.go 84.51% <0%> (+0.64%) ⬆️
pkg/util/util.go 67.56% <0%> (+1.35%) ⬆️
server/plugin/pkg/registry/etcd/tracing.go 81.81% <0%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a54da2...16e3882. Read the comment docs.

Copy link
Member

@asifdxtreme asifdxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asifdxtreme asifdxtreme merged commit bd59e8b into apache:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants