Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-988 Add loadbalancer in sc client #479

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Conversation

little-cui
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@little-cui little-cui self-assigned this Nov 1, 2018
@codecov-io
Copy link

Codecov Report

Merging #479 into master will increase coverage by 0.04%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
+ Coverage   60.24%   60.29%   +0.04%     
==========================================
  Files         156      157       +1     
  Lines       13484    13501      +17     
==========================================
+ Hits         8124     8140      +16     
- Misses       4779     4780       +1     
  Partials      581      581
Impacted Files Coverage Δ
pkg/lb/roundrobin.go 94.11% <94.11%> (ø)
pkg/tlsutil/tlsutil.go 73.58% <0%> (-0.95%) ⬇️
server/broker/service.go 57.94% <0%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb3aea0...57342eb. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 62.651% when pulling 57342eb on little-cui:lb into eb3aea0 on apache:master.

Copy link
Member

@asifdxtreme asifdxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asifdxtreme asifdxtreme merged commit dc76a75 into apache:master Nov 2, 2018
@little-cui little-cui deleted the lb branch November 9, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants