some improvements for documents #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jyseanl
commented
Jun 24, 2018
jyseanl
commented
- Modify the incorrect sample code.
- Add notes on policies' configuration.
- Replace 'cse' with 'servicecomb'.
- Improve the description of isolation.
- Fix typos.
Conflicts: _users/Metrics.md
1. Modify the incorrect sample code. 2. Add note on policies' configuration. 3. Fix Typo.
- Modify the incorrect sample code. - Add note on policies' configuration. - Replace 'cse' with 'servicecomb'. - Improve the description of isolation.
- Improve translation on service discovery. - Fix typo.
|
Hi I want to merge my commits to the master branch but seems a bunch of previous commits were packed together, could you just merge the 7 verified commits if you don't want the rest ones? |
|
@jyseanl I think I already merge the patch. If you don't have any other change, you can close the PR. |
|
Okay, no other changes, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.