Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace io.servicecomb to org.apache.servicecomb #34

Merged
merged 5 commits into from Apr 4, 2018

Conversation

zhengyangyong
Copy link

Signed-off-by: zhengyangyong yangyong.zheng@huawei.com

replace io.servicecomb to org.apache.servicecomb

@@ -23,7 +23,7 @@ Before we start, we need to add some common dependencies in the parent project o
<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.servicecomb</groupId>
<groupId>org.apache.servicecomb</groupId>
<artifactId>java-chassis-dependencies</artifactId>
<version>0.5.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.5.0 the package name of servicecomb is still io.servicecomb. We change it since 0.6.0-SNAPSHOT.

@@ -68,7 +68,7 @@ redirect_from:
<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.servicecomb</groupId>
<groupId>org.apache.servicecomb</groupId>
<artifactId>java-chassis-dependencies</artifactId>
<version>0.2.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the version here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -102,7 +102,7 @@ redirect_from:
<scope>import</scope>
</dependency>
<dependency>
<groupId>io.servicecomb</groupId>
<groupId>org.apache.servicecomb</groupId>
<artifactId>java-chassis-dependencies</artifactId>
<version>0.2.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the version here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -23,7 +23,7 @@ last_modified_at: 2017-09-04T10:01:43-04:00
<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.servicecomb</groupId>
<groupId>org.apache.servicecomb</groupId>
<artifactId>java-chassis-dependencies</artifactId>
<version>0.5.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the version here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@zhengyangyong
Copy link
Author

We will update all version from 0.6.0-SNAPSHOT to 1.0.0-m1-SNAPSHOT later

zhengyangyong added 4 commits April 3, 2018 09:03
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
@zhengyangyong
Copy link
Author

change version to 1.0.0-m1

<artifactId>java-chassis-dependencies</artifactId>
<version>0.2.0</version>
<version>0.6.0-SNAPSHOT</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update this version too

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<artifactId>java-chassis-dependencies</artifactId>
<version>0.2.0</version>
<version>0.6.0-SNAPSHOT</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update this version too

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<artifactId>java-chassis-dependencies</artifactId>
<version>0.5.0</version>
<version>0.6.0-SNAPSHOT</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may just do a global search for the old version and replaced with a new one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
@WillemJiang WillemJiang merged commit 722ceec into apache:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants