Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group by with keyword alias miss back quote when rewriting #2838

Closed
tuohai666 opened this issue Aug 9, 2019 · 1 comment
Closed

group by with keyword alias miss back quote when rewriting #2838

tuohai666 opened this issue Aug 9, 2019 · 1 comment
Assignees
Milestone

Comments

@tuohai666
Copy link
Member

Bug Report

For English only, other languages will not accept.

Before report a bug, make sure you have:

Please pay attention on issues you submitted, because we maybe need more details.
If no response more than 7 days and we cannot reproduce it on current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Which version of ShardingSphere did you use?

4.0.0-RC2-SNAPSHOT

Which project did you use? Sharding-JDBC or Sharding-Proxy?

Sharding-JDBC and Sharding-Proxy

Expected behavior

logical SQL:
SELECT SUM(order_id) AS orders_sum, user_id as key FROM t_order GROUP BY key
actual SQL:
SELECT SUM(order_id) AS orders_sum, user_id as key FROM t_order GROUP BY key ORDER BY 'key' ASC

Actual behavior

SELECT SUM(order_id) AS orders_sum, user_id as key FROM t_order GROUP BY key ORDER BY key ASC

Reason analyze (If you can)

miss back quote when rewriting

Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc.

Example codes for reproduce this issue (such as a github link).

@tuohai666
Copy link
Member Author

tuohai666 commented Aug 9, 2019

Fixed via #2817

@tuohai666 tuohai666 self-assigned this Aug 9, 2019
@tuohai666 tuohai666 added this to the 4.0.0-RC2 milestone Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant