Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 3303 #3305

Merged
merged 4 commits into from
Oct 17, 2019
Merged

Fix bug 3303 #3305

merged 4 commits into from
Oct 17, 2019

Conversation

tristaZero
Copy link
Contributor

Fixes #3303 .

@terrymanu terrymanu self-requested a review October 17, 2019 07:13
@terrymanu terrymanu added this to the 4.0.0-RC3 milestone Oct 17, 2019
@coveralls
Copy link

coveralls commented Oct 17, 2019

Pull Request Test Coverage Report for Build 685

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 118 unchanged lines in 22 files lost coverage.
  • Overall coverage increased (+0.002%) to 67.861%

Files with Coverage Reduction New Missed Lines %
sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/EncryptPreparedStatement.java 1 42.5%
sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlaveStatement.java 1 10.2%
sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingStatement.java 1 40.32%
sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/postgresql/packet/command/query/binary/bind/protocol/PostgreSQLStringBinaryProtocolValue.java 1 0.0%
sharding-ui/sharding-ui-backend/src/main/java/org/apache/shardingsphere/ui/security/UserAuthenticationService.java 1 0.0%
sharding-ui/sharding-ui-backend/src/main/java/org/apache/shardingsphere/ui/util/ConfigurationYamlConverter.java 1 0.0%
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java 2 2.38%
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-core/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/command/CommandExecutorTask.java 2 0.0%
sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlavePreparedStatement.java 3 6.49%
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/text/query/MySQLComQueryPacketExecutor.java 3 0.0%
Totals Coverage Status
Change from base Build 484: 0.002%
Covered Lines: 11305
Relevant Lines: 16659

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong parameter list when auto-generated key need to add.
3 participants