Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete projection assertion #4015

Merged
merged 25 commits into from
Jan 19, 2020
Merged

Complete projection assertion #4015

merged 25 commits into from
Jan 19, 2020

Conversation

terrymanu
Copy link
Member

For #3947.

Changes proposed in this pull request:

  • Complete generic projection assertion.
  • Complete shorthand projection assertion.
  • Complete column projection assertion.
  • Complete aggregation projection assertion.
  • Complete aggregation distinct projection assertion.
  • Complete expr projection assertion.
  • Complete top projection assertion.

@terrymanu
remove useless findSQLSegment in SQLStatementAssert
196e1e6
@terrymanu
assert projections's attribute
8d6a9c8
@terrymanu
distinctRow to distinct-row for xml
cde1abc
@terrymanu
fix assert text
bcfc8d0
@terrymanu
remove XmlElementWrapper
6b5cb0e
@terrymanu
refactor ExpectedProjections's field name
ff17d68
@terrymanu
rename ExpectedBaseProjection to AbstractExpectedProjection
d4a39c3
@terrymanu
refactor ExpectedProjections.findExpectedProjections()
32f7a7b
@terrymanu
add getStartIndex and getStopIndex for ExpectedProjection interface
0df390e
@terrymanu
add sort for projections
e300e3c
@terrymanu
add sort for projections
d18d45f
@terrymanu
remove useless getter for ExpectedProjections
06b86c4
@terrymanu
refactor ProjectionAssert.assertProjection
00281be
@terrymanu
add start index and stop index's assert for assertProjection
2743f74
@terrymanu
use int instead of Integer in ExpectedProjection
dfcb759
@terrymanu
use int instead of Integer in ExpectedProjections
b516b2e
@terrymanu
refactor ExpectedTableSegment
f1bfebb
@terrymanu
add assertShorthandProjection
6ddc590
@terrymanu
add assertShorthandProjection
117cbcf
@terrymanu
add assertColumnProjection
ffa24f2
@terrymanu
add assertAggregationProjection
2bbd24b
@terrymanu
add assertAggregationDistinctProjection
5464b86
@terrymanu
add assertExpressionProjection
a5a9d37
@terrymanu
add assertTopProjection
a6d3305
@terrymanu
remove ExpectedProjection.getText() and getParameterMarkerText()
4b53f23
@terrymanu terrymanu added this to the 5.0.0 milestone Jan 19, 2020
@dongzl dongzl merged commit 9405b25 into apache:dev Jan 19, 2020
@terrymanu terrymanu deleted the parser branch January 19, 2020 01:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1412

  • 5 of 7 (71.43%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.521%
Changes Missing Coverage Covered Lines Changed/Added Lines %
shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/select/item/impl/TopProjectionExtractor.java 0 2 0.0%
Totals Coverage Status
Change from base Build 701: 0.0%
Covered Lines: 10813
Relevant Lines: 16503
💛 - Coveralls

@terrymanu terrymanu modified the milestones: 5.0.0, 4.1.0 Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongzl dongzl dongzl approved these changes

Assignees
No one assigned
Labels
in: SQL parse in: test
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terrymanu @coveralls @dongzl