Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sharding scaling english documents #4932

Merged
merged 2 commits into from Mar 25, 2020
Merged

Add sharding scaling english documents #4932

merged 2 commits into from Mar 25, 2020

Conversation

KomachiSion
Copy link
Member

No description provided.

@KomachiSion KomachiSion added this to the 4.1.0 milestone Mar 25, 2020
@coveralls
Copy link

coveralls commented Mar 25, 2020 •
edited

Pull Request Test Coverage Report for Build 10571

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 26 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.09%) to 58.069%
Files with Coverage Reduction New Missed Lines %
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/engine/ShardingSQLRewriteEngine.java 1 95.65%
sharding-core/sharding-core-entry/src/main/java/org/apache/shardingsphere/core/shard/BaseShardingEngine.java 2 93.18%
sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java 3 76.0%
sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/TableRule.java 5 89.77%
sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java 7 76.47%
sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java 8 51.85%
Totals Coverage Status
Change from base Build 1163: -0.09%
Covered Lines: 11874
Relevant Lines: 20448
💛 - Coveralls

terrymanu
terrymanu requested changes Mar 25, 2020
View reviewed changes
sharding-scaling/README.md Outdated
@@ -8,7 +8,7 @@ The following figure may clearly express this component's role:

Supplementary instruction about the figure:

1. Support to migrate whole tables in sharding configuration only, can't support to migrate specified tables.
1. Support to migrate tables in shardingRule configuration only, can't support to migrate specified tables.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use camel case in document

@terrymanu terrymanu merged commit ea59c7b into apache:master Mar 25, 2020
@KomachiSion KomachiSion deleted the master-scaling-doc branch March 27, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrymanu terrymanu terrymanu approved these changes

Assignees
No one assigned
Labels
feature: pipeline in: document
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KomachiSion @coveralls @terrymanu