Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUES#4249]perfect plug-loggingClickHouse & refactor code #4296

Merged
merged 16 commits into from Jan 12, 2023
Merged

[ISSUES#4249]perfect plug-loggingClickHouse & refactor code #4296

merged 16 commits into from Jan 12, 2023

Conversation

misaya295
Copy link
Contributor

@misaya295 misaya295 commented Jan 3, 2023

about #4249

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #4296 (e11a3b1) into master (d4d0229) will decrease coverage by 0.43%.
The diff coverage is 67.74%.

@@             Coverage Diff              @@
##             master    #4296      +/-   ##
============================================
- Coverage     68.27%   67.83%   -0.44%     
+ Complexity     7467     7434      -33     
============================================
  Files          1015     1015              
  Lines         28730    28726       -4     
  Branches       2576     2572       -4     
============================================
- Hits          19614    19487     -127     
- Misses         7583     7714     +131     
+ Partials       1533     1525       -8     
Impacted Files Coverage Δ
.../clickhouse/config/ClickHouseLogCollectConfig.java 77.77% <0.00%> (-22.23%) ⬇️
...clickhouse/constant/ClickHouseLoggingConstant.java 0.00% <ø> (ø)
.../clickhouse/client/ClickHouseLogCollectClient.java 85.07% <84.00%> (-1.29%) ⬇️
...n/alibaba/dubbo/cache/AlibabaDubboConfigCache.java 46.59% <0.00%> (-30.69%) ⬇️
.../client/server/consul/ShenyuConsulConfigWatch.java 58.33% <0.00%> (-27.09%) ⬇️
...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java 75.00% <0.00%> (-25.00%) ⬇️
...he/shenyu/common/timer/HierarchicalWheelTimer.java 68.00% <0.00%> (-18.00%) ⬇️
...va/org/apache/shenyu/common/timer/TimingWheel.java 73.80% <0.00%> (-16.67%) ⬇️
...ava/org/apache/shenyu/admin/utils/SessionUtil.java 78.94% <0.00%> (-15.79%) ⬇️
...che/shenyu/sync/data/http/HttpSyncDataService.java 70.40% <0.00%> (-15.31%) ⬇️
... and 23 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 added this to the 2.5.1 milestone Jan 12, 2023
@yu199195 yu199195 merged commit 343fe1f into apache:master Jan 12, 2023
@misaya295 misaya295 deleted the loggingclickhouse-option branch January 15, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants