We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PENDING_SYNC was not set when checking upstream successfully, resulting in unable to update the handler of selector
private void check(final String selectorId, final List upstreamList) { List successList = Lists.newArrayListWithCapacity(upstreamList.size()); for (CommonUpstream commonUpstream : upstreamList) { final boolean pass = UpstreamCheckUtils.checkUrl(commonUpstream.getUpstreamUrl()); if (pass) { if (!commonUpstream.isStatus()) { commonUpstream.setTimestamp(System.currentTimeMillis()); commonUpstream.setStatus(true); // add PENDING_SYNC PENDING_SYNC.add(commonUpstream.hashCode()); LOG.info("UpstreamCacheManager check success the url: {}, host: {} ", commonUpstream.getUpstreamUrl(), commonUpstream.getUpstreamHost()); } successList.add(commonUpstream); ................
No response
ShenYu version(s):2.5.0
The text was updated successfully, but these errors were encountered:
fix apache#4298 zombie -> pass update PENDING_SYNC
337533a
fix #4298 zombie -> pass update PENDING_SYNC (#4430)
8695376
Co-authored-by: xiaoyu <xiaoyu@apache.org>
Successfully merging a pull request may close this issue.
Is there an existing issue for this?
Current Behavior
PENDING_SYNC was not set when checking upstream successfully, resulting in unable to update the handler of selector
Expected Behavior
private void check(final String selectorId, final List upstreamList) {
List successList = Lists.newArrayListWithCapacity(upstreamList.size());
for (CommonUpstream commonUpstream : upstreamList) {
final boolean pass = UpstreamCheckUtils.checkUrl(commonUpstream.getUpstreamUrl());
if (pass) {
if (!commonUpstream.isStatus()) {
commonUpstream.setTimestamp(System.currentTimeMillis());
commonUpstream.setStatus(true);
// add PENDING_SYNC
PENDING_SYNC.add(commonUpstream.hashCode());
LOG.info("UpstreamCacheManager check success the url: {}, host: {} ", commonUpstream.getUpstreamUrl(), commonUpstream.getUpstreamHost());
}
successList.add(commonUpstream);
................
Steps To Reproduce
No response
Environment
Debug logs
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: