[ISSUE #3318] Fix keep waiting for acquiring memory unexpectedly #3335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unexpectedly error and add unit test.
yu199195
reviewed
Apr 26, 2022
| final long objectSize = inst.getObjectSize(o); | ||
| while (sum + objectSize >= memoryLimit) { | ||
| while (memory.sum() + objectSize >= memoryLimit) { |
There was a problem hiding this comment.
hi，sum + objectSize and memory.sum() + objectSize
What's the difference?
There was a problem hiding this comment.
In the while loop, memory.sum() gets the latest value.
…unexpectedly error and add unit test.
Codecov Report
@@ Coverage Diff @@
## master #3335 +/- ##
============================================
+ Coverage 65.40% 65.71% +0.30%
- Complexity 5204 5230 +26
============================================
Files 746 746
Lines 21020 21024 +4
Branches 1919 1920 +1
============================================
+ Hits 13749 13816 +67
+ Misses 5992 5925 -67
- Partials 1279 1283 +4
Continue to review full report at Codecov.
|
loongs-zhang
approved these changes
Apr 26, 2022
|
@Albertsirius thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3318 , fix
MemoryLimiter.acquireInterruptiblykeep waiting unexpectedly error. Add an unit test classMemoryLimiterTestMake sure that:
mvn clean install -Dmaven.javadoc.skip=true.