SINGA -475 add Sub operator implementation to singa #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinpom
changed the title
joddiy
requested changes
Aug 1, 2019
test/python/test_operation.py
Outdated
| dx=result.creator.backward(x.data)[0] | ||
|
|
||
| result_np=np.subtract(X,Y) | ||
| np.testing.assert_array_almost_equal(tensor.to_numpy(result), result_np) |
There was a problem hiding this comment.
please add the test case of backward propagation.
chrishkchris
reviewed
Aug 7, 2019
python/singa/autograd.py
Outdated
|
|
||
| class Sub(Operation): | ||
| def __init__(self): | ||
| super(Sub, self)._init_() |
There was a problem hiding this comment.
line1835: super(Sub, self)._init_()
should be
super(Sub, self).__init__()
|
Tested on cloud K80 with the code. Ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.