Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hope to add hostname or ip to traceSegment or span #1248

Closed
1 of 4 tasks
candyleer opened this issue May 21, 2018 · 4 comments
Closed
1 of 4 tasks

Hope to add hostname or ip to traceSegment or span #1248

candyleer opened this issue May 21, 2018 · 4 comments
Assignees
Labels
question End user question and discussion.
Milestone

Comments

@candyleer
Copy link
Member

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Question

  • What do you want to know?

Bug

  • Which version of SkyWalking, OS and JRE?

  • Which company or project?

  • What happen?
    If possible, provide a way for reproducing the error. e.g. demo application, component version.


Requirement or improvement

  • Please describe about your requirements or improvement suggestions.

Now,I have an application and it is slow in some machine, but i don't know which machine, so Do we need add hostname or other info to traceSegment or add tag to span?

@wu-sheng
Copy link
Member

Now,I have an application and it is slow in some machine, but i don't know which machine, so Do we need add hostname or other info to traceSegment or add tag to span?

There is an application id and instance id in every segment, which include application code, machine info, such as ip, hostname, processid.

I think I can move this into a query requirement for trace, to discuss whether could we provide this in beta2.

@wu-sheng wu-sheng added backend OAP backend related. UI UI and front end related. feature New feature labels May 21, 2018
@wu-sheng
Copy link
Member

@hanahmily @peng-yongsheng What do you think about this in beta2? It makes sense in some cases. I am just not sure about the milestone.

@peng-yongsheng
Copy link
Member

I'm ok. Collector and UI are easy to support it. But there were so many agent plugins need to develop and test.

@wu-sheng
Copy link
Member

wu-sheng commented Jun 9, 2018

From the application instance id, backend knows already. No need to adjust any plugin.

@wu-sheng wu-sheng added this to the 6.1.0 milestone Apr 3, 2019
@wu-sheng wu-sheng added question End user question and discussion. and removed backend OAP backend related. UI UI and front end related. feature New feature labels Apr 3, 2019
@wu-sheng wu-sheng closed this as completed Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question End user question and discussion.
Projects
None yet
Development

No branches or pull requests

4 participants