Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's a bit of doubt about the way springMVC gets the operationName #1302

Closed
1 of 4 tasks
liu-junchi opened this issue Jun 4, 2018 · 4 comments
Closed
1 of 4 tasks
Assignees
Labels
agent Language agent related. question End user question and discussion.
Milestone

Comments

@liu-junchi
Copy link
Contributor

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Question

  • What do you want to know?
    Like this,
    image
    the RequestMappingMethodInterceptor#getRequestURL just get the RequestMapping annotation's path or value as operationName, I think maybe I need the parsed path as operationName.
@wu-sheng
Copy link
Member

wu-sheng commented Jun 4, 2018

Yes. only use path pattern as the operation name, the backend will aggregate and analysis the metrics for the service(based on operation name).

@liu-junchi
Copy link
Contributor Author

What's the difference, if the operationName use parsed path pattern~

@wu-sheng
Copy link
Member

wu-sheng commented Jun 4, 2018

I guess parsed path pattern, you mean the real URL?

  • Pattern: ${spring.application.name}/access/page
  • URI: application-xxx/access/page

Right? If yes, try to think some one will put userid, accountid in the url, the patten looks like /prod/order/${orderid}. Then you can image what happens... Metrics will be useless..

@liu-junchi
Copy link
Contributor Author

Thanks, I get it.

@wu-sheng wu-sheng self-assigned this Jun 4, 2018
@wu-sheng wu-sheng added this to the 5.0.0-beta2 milestone Jun 4, 2018
@wu-sheng wu-sheng added question End user question and discussion. agent Language agent related. labels Jun 4, 2018
@wu-sheng wu-sheng closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. question End user question and discussion.
Projects
None yet
Development

No branches or pull requests

2 participants