Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agent] Can skywalking support Hystrix #612

Closed
menglongfeihu opened this issue Nov 21, 2017 · 6 comments
Closed

[Agent] Can skywalking support Hystrix #612

menglongfeihu opened this issue Nov 21, 2017 · 6 comments
Assignees
Labels
agent Language agent related.
Milestone

Comments

@menglongfeihu
Copy link

Please answer these questions before submitting your issue.

What version of sky-walking are you using?

3.2.4

What company or project?

just learn

What did you do?

If possible, provide a way for reproducing the error. e.g. demo application, component version.

@wu-sheng
Copy link
Member

@ascrutae Hystrix breaks the trace, possibly caused by *multi thread scenario.

@ascrutae
Copy link
Member

ascrutae commented Dec 1, 2017

I will support this plugin in next version

@wu-sheng wu-sheng added this to the 5.0-2018-preview milestone Dec 12, 2017
@wu-sheng wu-sheng changed the title Can skywalking support Hystrix [Agent] Can skywalking support Hystrix Dec 12, 2017
@iHuangYaoshi
Copy link

expect the Hystrix plugin

@wu-sheng
Copy link
Member

@KaiwenWang Received your feedback. Hope @ascrutae will have time to do so. He is working on automatic tests now.

@wu-sheng wu-sheng added the agent Language agent related. label Feb 8, 2018
@wu-sheng
Copy link
Member

@ascrutae Pay attention for the multi threads in Hystrix. This component is really important in Spring eco system. But be advised, create span for Hystrix is meaningless, but tracing retry by creating new thread and propagate context, also log the exception it triggers. those are really matter.

@ascrutae
Copy link
Member

ascrutae commented Feb 27, 2018

Hystrix plugin has been merged. Close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related.
Projects
None yet
Development

No branches or pull requests

4 participants