Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mssql jdbc monitoring #858

Closed
1 of 4 tasks
zone1511 opened this issue Mar 1, 2018 · 7 comments
Closed
1 of 4 tasks

Add support for mssql jdbc monitoring #858

zone1511 opened this issue Mar 1, 2018 · 7 comments
Labels
question End user question and discussion. wontfix This will not be worked on
Milestone

Comments

@zone1511
Copy link

zone1511 commented Mar 1, 2018

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Requirement or improvement

Currently H2,mysql,oracle and postgresql jdbc monitoring are supported. I can contribute the mssql jdbc monitoring component

@wu-sheng
Copy link
Member

wu-sheng commented Mar 1, 2018

sure. welcome. And i think you are familiar with our plugin process.

BTW, because rocketmq 3.x plugin has been merged, please send a pr to update supported list document.

@wu-sheng wu-sheng added agent Language agent related. feature New feature labels Mar 1, 2018
@zone1511
Copy link
Author

zone1511 commented Mar 2, 2018 via email

@wu-sheng
Copy link
Member

wu-sheng commented Mar 2, 2018

@zone1511 The test just begin, follow #855 for update. And you should join gitter for our discussions and news post.

@wu-sheng
Copy link
Member

wu-sheng commented Mar 2, 2018

@zone1511 And https://github.com/SkywalkingTest/skywalking-agent-testcases/blob/master/docs/how-to-write-a-plugin-testcase-cn.md this is a plugin test guide, if any plugin merged into master, you should follow.

@zone1511
Copy link
Author

zone1511 commented Mar 5, 2018

@wu-sheng after I run the local scenario test, I make a pr to https://github.com/SkywalkingTest/skywalking-agent-testcases as well?

@wu-sheng
Copy link
Member

wu-sheng commented Mar 6, 2018

There is a cn document to guide you to provide test cases. https://github.com/SkywalkingTest/skywalking-agent-testcases/blob/master/docs/how-to-write-a-plugin-testcase-cn.md

All cases in that repo will run automatically daily.

@wu-sheng wu-sheng added this to the 6.0.0-beta milestone Nov 20, 2018
@wu-sheng wu-sheng added question End user question and discussion. wontfix This will not be worked on and removed agent Language agent related. feature New feature labels Nov 20, 2018
@wu-sheng
Copy link
Member

Not active, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question End user question and discussion. wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants