Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the document #1328

Closed
wants to merge 1 commit into from
Closed

Modify the document #1328

wants to merge 1 commit into from

Conversation

SoberChina
Copy link
Contributor

Please answer these questions before submitting pull request

  • Why submit this pull request?
    Modify the document

  • Related issues


Bug fix

  • Bug description.

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

set "CATALINA_OPTS=-javaagent:/path/to/skywalking-agent/skywalking-agent.jar"
```
- Spring Boot JAR file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also fits all jar file start up. Recommend remove Spring, or just mention Spring in contents, not title.

Change the boot command
```shell
java -javaagent:/path/to/skywalking-agent/skywalking-agent.jar -jar youProject.jar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

youProject -> yourProject

java -javaagent:/path/to/skywalking-agent/skywalking-agent.jar -jar youProject.jar
```
> windows path eg: `E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need a windows path?

@SoberChina SoberChina closed this Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants