Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify the document #1331

Merged
merged 4 commits into from Jun 8, 2018
Merged

modify the document #1331

merged 4 commits into from Jun 8, 2018

Conversation

SoberChina
Copy link
Contributor

Please answer these questions before submitting pull request

  • Why submit this pull request?
    modify the document
  • Related issues

Bug fix

  • Bug description.

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

@wu-sheng wu-sheng added this to the 5.0.0-beta2 milestone Jun 8, 2018
@wu-sheng wu-sheng added the documentation Provide documents related issue or pull request only. label Jun 8, 2018
@SoberChina
Copy link
Contributor Author

The pr #1330 is in conflict with me.

```
- JAR file
Change the boot command
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to recommend you to change your English expression.

  • My suggestion
    Add -javaagent argument to command line in which you start your app. And make sure to add it before the -jar argument.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

@wu-sheng wu-sheng merged commit a6d9a60 into apache:master Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provide documents related issue or pull request only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants