Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix #1549, spring-plugins bug #1554
I think that this is not the root cause about #1549, I suspect that the problem is caused by that the plugin only stores the Request and does not store Response。because of the plugin had check if Request is empty when creating span in beforeMethod and the plugin check the Response is empty when finish the span in afterMethod.
Can you provide more detail or another fix for this? If plugin checked, where does the span come from? Any other plugin leak the span?
@ylywyn Because the
yes, this is not the root cause about #1549. context has been removed before AbstractMethodInterceptor::afterMethod.
callstack like this:
5: AbstractMethodInterceptor::afterMethod context is null . ContextManager.stopSpan() can't be call
3: InvokeForRequestInterceptor::afterMethod context[SW_REQUEST] -> context
1: InvokeForRequestInterceptor::beforeMethod context[SW_REQUEST] -> context[SW_REQUEST, SW_RESPONSE]