Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AntPathMatcher and ot.SkywalkingSpanBuilder bugs #2055

Merged
merged 2 commits into from Dec 16, 2018
Merged

fix AntPathMatcher and ot.SkywalkingSpanBuilder bugs #2055

merged 2 commits into from Dec 16, 2018

Conversation

zhaoyuguang
Copy link
Member

@zhaoyuguang zhaoyuguang commented Dec 16, 2018 •
edited

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

Bug fix

  • Fix some obvious minor bugs.

@zhaoyuguang zhaoyuguang mentioned this pull request Dec 16, 2018
Merged
@IanCao IanCao requested a review from wu-sheng December 16, 2018 15:19
@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! agent Language agent related. labels Dec 16, 2018
@wu-sheng wu-sheng changed the title fix some obvious minor bugs fix AntPathMatcher and ot.SkywalkingSpanBuilder bugs Dec 16, 2018
@coveralls
Copy link

coveralls commented Dec 16, 2018 •
edited

Coverage Status

Coverage increased (+0.002%) to 14.325% when pulling 54f5398 on zhaoyuguang:master into 8eb1bb1 on apache:master.

@wu-sheng wu-sheng modified the milestones: 5.1.0, 6.0.0-GA Dec 16, 2018
@wu-sheng wu-sheng merged commit 3fdab2f into apache:master Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
agent Language agent related. bug Something isn't working and you are sure it's a bug!
Projects
None yet
Milestone
6.0.0-GA
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhaoyuguang @coveralls @wu-sheng