Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish code #2332

Merged
merged 2 commits into from Mar 8, 2019
Merged

polish code #2332

merged 2 commits into from Mar 8, 2019

Conversation

kezhenxu94
Copy link
Member

Please answer these questions before submitting pull request

  • Why submit this pull request?
  • Bug fix
  • New feature provided
  • Improve performance
  • Polish code

New feature or improvement

  • Describe the details and related test reports.
    Since java.lang.ClassLoader#getSystemClassLoader is a static method, we can just call ClassLoader.getSystemClassLoader() for simplicity and suppress IDE warnings.

@wu-sheng wu-sheng added this to the 6.1.0 milestone Mar 8, 2019
@wu-sheng wu-sheng added the agent Language agent related. label Mar 8, 2019
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me. I have noticed this before, good catch.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 13.874% when pulling adf9a74 on kezhenxu94:polishing into c157b94 on apache:master.

@wu-sheng wu-sheng merged commit a69d073 into apache:master Mar 8, 2019
@kezhenxu94 kezhenxu94 deleted the polishing branch March 8, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants