Submit related projects in NOTICE. #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
added
the
documentation
michaelsembwever
requested changes
Dec 16, 2017
NOTICE.txt
Outdated
| mockito: http://site.mockito.org/ | ||
| QOS.ch (slf4j): https://www.slf4j.org/ | ||
| powermock: https://github.com/powermock/powermock | ||
| Eclipse (Jetty): https://www.eclipse.org/jetty/ |
There was a problem hiding this comment.
for each of the dependencies you need to say which license they use.
Add licenses for each dependency.
|
@michaelsembwever The season I didn't add license, is because the two examples don't include that, https://github.com/apache/cassandra/blob/trunk/NOTICE.txt and https://github.com/apache/tiles/blob/trunk/NOTICE.txt . But anyway, I have added them already. :) |
michaelsembwever
approved these changes
Dec 19, 2017
|
looks good! thanks @wu-sheng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@michaelsembwever :
I add the NOTICE file, which includes the related projects in distribution. You can find many dependencies in our project is
providedonly, so I did't list them all, we just instrument them, not using them.FYI @hanahmily you need to create the same NOTICE file in
incubator-skywalking-uirepository too.CC @apache/skywalking-committers