Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Agent-Plugin] Add support to MysqlDataSource #701

Merged
merged 2 commits into from Dec 25, 2017
Merged

[Agent-Plugin] Add support to MysqlDataSource #701

merged 2 commits into from Dec 25, 2017

Conversation

jjtyro
Copy link
Contributor

@jjtyro jjtyro commented Dec 23, 2017 •
edited

MysqlDataSource use com.mysql.jdbc.NonRegisteringDriver，not com.mysql.jdbc.Driver.
Add it to Agent's mysql-5.x-plugin to support the application which using MysqlDataSource. #699

@wu-sheng
Copy link
Member

@jjtyro This pull request seems good enough, but you have a conflict. Please resolve it first.

@wu-sheng wu-sheng self-requested a review December 23, 2017 14:38
@wu-sheng wu-sheng added this to the 5.0.0-alpha milestone Dec 23, 2017
@wu-sheng wu-sheng added the bug Something isn't working and you are sure it's a bug! label Dec 23, 2017
wu-sheng
wu-sheng requested changes Dec 25, 2017
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solve the conflict, please.

wu-sheng
wu-sheng approved these changes Dec 25, 2017
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FYI @ascrutae , you should add this driver into your test case.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 23.005% when pulling 35610fa on jjtyro:fix-agent-to-support-mysqldatasource into 6b288b3 on apache:master.

@wu-sheng wu-sheng merged commit 720f404 into apache:master Dec 25, 2017
@wu-sheng
Copy link
Member

@jjtyro Thanks for you helps.

@jjtyro
Copy link
Contributor Author

jjtyro commented Dec 25, 2017

@wu-sheng no tks!

@jjtyro jjtyro deleted the fix-agent-to-support-mysqldatasource branch December 25, 2017 06:14
@jjtyro jjtyro restored the fix-agent-to-support-mysqldatasource branch December 25, 2017 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@ascrutae ascrutae Awaiting requested review from ascrutae

Assignees
No one assigned
Labels
bug Something isn't working and you are sure it's a bug!
Projects
None yet
Milestone
5.0.0-alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjtyro @wu-sheng @coveralls