Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect the background processes. #741

Merged
merged 2 commits into from Jan 11, 2018
Merged

Protect the background processes. #741

merged 2 commits into from Jan 11, 2018

Conversation

wu-sheng
Copy link
Member

There is an important feature of ScheduledExecutorService. The timer could be suppressed with an exception in run().

encounters an exception, subsequent executions are suppressed.

I fix this by adding a new RunnableWithExceptionProtection.

@wu-sheng wu-sheng added the bug Something isn't working and you are sure it's a bug! label Jan 11, 2018
@wu-sheng wu-sheng added this to the 5.0.0-alpha milestone Jan 11, 2018
@wu-sheng wu-sheng self-assigned this Jan 11, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 22.252% when pulling 8f49c97 on fix/ScheduledFuture-failsafe into 3613691 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 22.252% when pulling 6c11a84 on fix/ScheduledFuture-failsafe into 2713b5f on master.

@wu-sheng wu-sheng merged commit 1ed8df8 into master Jan 11, 2018
@wu-sheng wu-sheng deleted the fix/ScheduledFuture-failsafe branch January 11, 2018 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peng-yongsheng peng-yongsheng peng-yongsheng approved these changes

Assignees

@wu-sheng wu-sheng

Labels
bug Something isn't working and you are sure it's a bug!
Projects
None yet
Milestone
5.0.0-alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wu-sheng @coveralls @peng-yongsheng