Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver #743

Merged
merged 2 commits into from Jan 11, 2018
Merged

[Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver #743

merged 2 commits into from Jan 11, 2018

Conversation

ascrutae
Copy link
Member

No description provided.

@ascrutae ascrutae added this to the 5.0.0-alpha milestone Jan 11, 2018
wu-sheng
wu-sheng requested changes Jan 11, 2018
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MultiClassNameMatch also exists in MySQL plugins. So from the real world, the multi match is common. Please refactor codes, and move it into the core match. Thanks.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.266% when pulling 97b5778 on ascrutae:support/postgresql-jdbc into 3613691 on apache:master.

@ascrutae
Copy link
Member Author

Done!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.266% when pulling 95cf5ac7a67cd9be9e11d23157ae626d9fcdee5e on ascrutae:support/postgresql-jdbc into 3613691 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.266% when pulling c6e593f on ascrutae:support/postgresql-jdbc into 3613691 on apache:master.

@ascrutae
Copy link
Member Author

Here is the report: https://github.com/SkywalkingTest/agent-integration-test-report/blob/master/2018/1/ascrutae/testReport-master-2018-01-11-19-44.md

@wu-sheng wu-sheng merged commit 2713b5f into apache:master Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0-alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ascrutae @coveralls @wu-sheng