Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"getTopNSlowService" service, change the attribute name from TPS to callsPerSec. #838

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

peng-yongsheng
Copy link
Member

  1. Changed the attribute name from TPS to callsPerSec.
  2. Calculate the callsPerSec.

INPUT

{
  getTopNSlowService(duration: {start: "2017-06-01 1002", end: "2017-06-01 1005", step: MINUTE}, topN: 10) {
    id, name, avgResponseTime, callsPerSec
  }
}

OUTPUT

{
  "data": {
    "getTopNSlowService": [
      {
        "id": "-2",
        "name": "/dubbox-case/case/dubbox-rest",
        "avgResponseTime": 2000,
        "callsPerSec": 20
      },
      {
        "id": "2",
        "name": "org.skywaking.apm.testcase.dubbo.services.GreetService.doBusiness()",
        "avgResponseTime": 1000,
        "callsPerSec": 20
      }
    ]
  }
}

@peng-yongsheng peng-yongsheng added backend OAP backend related. feature New feature labels Feb 28, 2018
@peng-yongsheng peng-yongsheng added this to the 5.0.0-alpha milestone Feb 28, 2018
@wu-sheng wu-sheng changed the title 1. Changed the attribute name from TPS to callsPerSec. "getTopNSlowService" service, change the attribute name from TPS to callsPerSec. Feb 28, 2018
@wu-sheng wu-sheng merged commit 4086122 into apache:master Feb 28, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 19.452% when pulling 2caa29a on peng-yongsheng:feature/getTopNSlowService into e90cfc8 on apache:master.

@peng-yongsheng peng-yongsheng deleted the feature/getTopNSlowService branch February 28, 2018 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants