-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed/855 #865
Merged
Merged
Fixed/855 #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peng-yongsheng
added
bug
Something isn't working and you are sure it's a bug!
backend
OAP backend related.
labels
Mar 3, 2018
@peng-yongsheng Please add your reply on #855 |
wu-sheng
approved these changes
Mar 3, 2018
wu-sheng
requested changes
Mar 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ServerType config and analysis based on them need to revert. @ascrutae misguide you.
2. Setting the src span type when agent register service name. 3. Revert the topology build logic.
|
wu-sheng
approved these changes
Mar 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dashboard [COLLECTOR] [APP_SERVICE_PROVIDED] [APP_STANDBY] The App value is incorrect.
Topology [COLLECTOR] [APP_SERVICE_PROVIDED] [APP_STANDBY] The topology doesn't display.
Application [COLLECTOR] [APP_SERVICE_PROVIDED] [APP_STANDBY] The select list does’t display.
Server:
[UNKNOWN] The select lis item description is not accurate
[COLLECTOR] The limit value of non-heap is negative number
[COLLECTOR] The limit value of heap is negative number
Service: [COLLECTOR] The call type of service topology is incorrect. the call type of all nodes is the same.
Trace: [COLLECTOR] The trace pagination is incorrect. the total number of data is 18, but no data in page 2.