Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed/855 #865

Merged
merged 9 commits into from
Mar 3, 2018
Merged

Fixed/855 #865

merged 9 commits into from
Mar 3, 2018

Conversation

peng-yongsheng
Copy link
Member

Dashboard [COLLECTOR] [APP_SERVICE_PROVIDED] [APP_STANDBY] The App value is incorrect.
Topology [COLLECTOR] [APP_SERVICE_PROVIDED] [APP_STANDBY] The topology doesn't display.
Application [COLLECTOR] [APP_SERVICE_PROVIDED] [APP_STANDBY] The select list does’t display.
Server:
[UNKNOWN] The select lis item description is not accurate
[COLLECTOR] The limit value of non-heap is negative number
[COLLECTOR] The limit value of heap is negative number
Service: [COLLECTOR] The call type of service topology is incorrect. the call type of all nodes is the same.
Trace: [COLLECTOR] The trace pagination is incorrect. the total number of data is 18, but no data in page 2.

@peng-yongsheng peng-yongsheng added bug Something isn't working and you are sure it's a bug! backend OAP backend related. labels Mar 3, 2018
@peng-yongsheng peng-yongsheng added this to the 5.0.0-alpha milestone Mar 3, 2018
@wu-sheng
Copy link
Member

wu-sheng commented Mar 3, 2018

@peng-yongsheng Please add your reply on #855

@coveralls
Copy link

coveralls commented Mar 3, 2018

Coverage Status

Coverage decreased (-0.008%) to 19.465% when pulling 0e61c97 on peng-yongsheng:fixed/855 into 0ef48ad on apache:master.

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ServerType config and analysis based on them need to revert. @ascrutae misguide you.

@peng-yongsheng
Copy link
Member Author

  1. Get the service id only when agent register service name.
  2. Setting the src span type when agent register service name.
  3. Revert the topology build logic.

@wu-sheng wu-sheng merged commit e7b3014 into apache:master Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. bug Something isn't working and you are sure it's a bug!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants