Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add npm install error tips. #970

Merged
merged 2 commits into from
Mar 20, 2018
Merged

add npm install error tips. #970

merged 2 commits into from
Mar 20, 2018

Conversation

cyberdak
Copy link
Contributor

@cyberdak cyberdak commented Mar 20, 2018 •
edited

tell people use taobao's npm source.

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

Bug fix

  • Bug description.

  • How to fix?

New feature or improvement

  • Describe the details and related test reports.

@cyberdak
add npm install error tips.
c6aab73 
tell people use taobao's npm source.
@coveralls
Copy link

coveralls commented Mar 20, 2018 •
edited

Coverage Status

Coverage remained the same at 19.191% when pulling 3f11ea4 on cyberdak:patch-3 into b5de1a1 on apache:master.

@wu-sheng wu-sheng added this to the 5.0.0-beta milestone Mar 20, 2018
@wu-sheng wu-sheng added documentation Provide documents related issue or pull request only. UI UI and front end related. labels Mar 20, 2018
@wu-sheng
Copy link
Member

FYI @hanahmily

@wu-sheng wu-sheng requested a review from hanahmily March 20, 2018 12:22
hanahmily
hanahmily approved these changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@hanahmily hanahmily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will help users in China

@wu-sheng wu-sheng merged commit 8106c38 into apache:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanahmily hanahmily hanahmily approved these changes

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
documentation Provide documents related issue or pull request only. UI UI and front end related.
Projects
None yet
Milestone
5.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cyberdak @coveralls @wu-sheng @hanahmily