Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella] Add testcontainer utils for integration test. #2896

Closed
3 tasks done
RocMarshal opened this issue Jul 25, 2023 · 1 comment
Closed
3 tasks done

[Umbrella] Add testcontainer utils for integration test. #2896

RocMarshal opened this issue Jul 25, 2023 · 1 comment

Comments

@RocMarshal
Copy link
Contributor

RocMarshal commented Jul 25, 2023

Code of Conduct

Search before asking

  • I had searched in the issues and found no similar issues.

Describe the proposal

Add test-container utils for integration test.

  • Support remote standalone session cluster.
  • Support yarn deployment mode.

Task list

Ignored. see comments.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@RocMarshal
Copy link
Contributor Author

RocMarshal commented Aug 30, 2023

Completed via

There are still some areas here where there is still room for improvement.

  • Maybe could reference to Flink Containers of flink-test-utils-junit

  • If the performance of the integration testing class is unstable, it is necessary to add junit5 RetryExtension or junit4 RetryRule to eliminate randomness.

  • It is unreasonable to download the Flink release package( 1.17.1 tgz now.) every time CI runs.

  • Place all integration test cases under a certain module for unified control. Reduce running frequency, reduce time consumption, and reduce download of Flink release packages.

The current strategy is only aimed at quickly supporting code quality improvement and the introduction of test cases.

CC @wolfboys @GOODBOY008 @wuchunfu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant