Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot edit datasources from the Pivot Table viz #10247

Closed
etr2460 opened this issue Jul 6, 2020 · 5 comments · Fixed by #10283
Closed

Cannot edit datasources from the Pivot Table viz #10247

etr2460 opened this issue Jul 6, 2020 · 5 comments · Fixed by #10283
Labels
change:frontend Requires changing the frontend !deprecated-label:bug Deprecated label - Use #bug instead

Comments

@etr2460
Copy link
Member

etr2460 commented Jul 6, 2020

When the pivot table viz is selected in Explore and I click on the datasource name, I don't see the option to edit the datasource, only change it or explore it in sql lab.

Expected results

See the option to edit the datasource

Actual results

Don't see that option

Screenshots

image

How to reproduce the bug

  1. Open a chart in explore
  2. Change it to viz type pivot-table
  3. Click on the datasource name
  4. don't see the edit datasource option

Environment

(please complete the following information):

  • superset version: master

@rusackas or @suddjian, do you think this is related to moving the pivot table controls into superset-ui? I know it happened a while ago, but I can't think of another reason for this to break, so tagging you here
@etr2460 etr2460 added the !deprecated-label:bug Deprecated label - Use #bug instead label Jul 6, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.92. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@etr2460 etr2460 added .explore change:frontend Requires changing the frontend labels Jul 6, 2020
@suddjian
Copy link
Member

suddjian commented Jul 8, 2020

I don't see anything suspicious at first glance in the control config. I can do a deeper investigation later today.

@etr2460
Copy link
Member Author

etr2460 commented Jul 9, 2020

Thanks @suddjian!

@mistercrunch
Copy link
Member

Oh hit this issue too and found a solution. I'm guessing this is related to the controls refactor (?)

@mistercrunch mistercrunch mentioned this issue Jul 10, 2020
Merged
mistercrunch added a commit to preset-io/superset that referenced this issue Jul 10, 2020
@mistercrunch
fix(explore): 'Edit Datasource' is missing from btn-dropdown
3be0c60 
Not sure how it got broken but he's a fix. I'm thinking this is related
to the controls refactor.

closes apache#10247
@mistercrunch
Copy link
Member

See fix here #10283

ktmud pushed a commit that referenced this issue Jul 10, 2020
@mistercrunch
fix(explore): 'Edit Datasource' is missing from btn-dropdown (#10283)
7d4d2e7 
Not sure how it got broken but he's a fix. I'm thinking this is related
to the controls refactor.

closes #10247
auxten pushed a commit to auxten/incubator-superset that referenced this issue Nov 20, 2020
@mistercrunch @auxten
fix(explore): 'Edit Datasource' is missing from btn-dropdown (apache#…
fa58c71 
…10283)

Not sure how it got broken but he's a fix. I'm thinking this is related
to the controls refactor.

closes apache#10247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change:frontend Requires changing the frontend !deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(explore): 'Edit Datasource' is missing from btn-dropdown preset-io/superset
3 participants
@mistercrunch @suddjian @etr2460