feat(dashboard): Let users re-arrange native filters #16154

m-ajay · 2021-08-09T20:28:29Z

SUMMARY

Allows users to re-arrange the dashboard native filters

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Click Edit icon (✏️) in native filters section on the left side of the dashboard
Re-arrange the native filters in the opened modal box
Save and verify that the order has changed in the UI

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

…/native-filter-rearrage

codecov · 2021-08-09T20:45:28Z

Codecov Report

Merging #16154 (06bf6eb) into master (5e85f48) will increase coverage by 0.02%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##           master   #16154      +/-   ##
==========================================
+ Coverage   76.88%   76.91%   +0.02%     
==========================================
  Files        1031     1034       +3     
  Lines       55183    55381     +198     
  Branches     7505     7545      +40     
==========================================
+ Hits        42430    42594     +164     
- Misses      12501    12538      +37     
+ Partials      252      249       -3

Flag	Coverage Δ
javascript	`70.90% <76.47%> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ilters/FilterBar/FilterConfigurationLink/index.tsx	`100.00% <ø> (ø)`
...mponents/nativeFilters/FiltersConfigModal/state.ts	`81.25% <0.00%> (+4.77%)`	⬆️
...mponents/nativeFilters/FiltersConfigModal/utils.ts	`65.64% <55.76%> (-4.73%)`	⬇️
...ilters/FiltersConfigModal/FilterTitleContainer.tsx	`64.51% <64.51%> (ø)`
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx	`69.25% <72.22%> (-2.36%)`	⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx	`87.50% <85.48%> (-1.85%)`	⬇️
...ilters/FilterBar/FilterControls/FilterControls.tsx	`80.00% <87.50%> (ø)`
...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx	`92.00% <92.00%> (ø)`
...tiveFilters/FiltersConfigModal/DraggableFilter.tsx	`92.30% <92.30%> (ø)`
...omponents/nativeFilters/FilterBar/Header/index.tsx	`100.00% <100.00%> (ø)`
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e85f48...06bf6eb. Read the comment docs.

junlincc · 2021-08-09T22:29:01Z

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

github-actions · 2021-08-09T22:30:45Z

@junlincc Ephemeral environment spinning up at http://34.209.125.69:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

jinghua-qa · 2021-08-09T23:00:49Z

I have tested in the test environment, the drag and drop is not accurate, it always drop the filter to the bottom no matter i move up or move down, some time i just want to change the filter position from 1st to 2nd and it was dropped to the last

Screen.Recording.2021-08-09.at.3.56.13.PM.mov

m-ajay · 2021-08-10T20:14:24Z

@jinghua-qa Thanks for testing. It happens when we newly add filters and try re-arrange them. I have fixed it now.

rusackas · 2021-10-13T16:39:38Z

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

github-actions · 2021-10-13T16:45:01Z

@rusackas Ephemeral environment spinning up at http://34.217.68.142:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

graceguo-supercat · 2021-10-13T18:42:38Z

@m-ajay i found a issue in the latest build: for the last added component, its column value sometimes now showing up:

...ashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx

michael-s-molina · 2021-10-14T18:29:03Z

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

github-actions · 2021-10-14T18:33:43Z

@michael-s-molina Ephemeral environment spinning up at http://35.85.223.220:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

michael-s-molina · 2021-10-14T18:53:50Z

I found this weird bug after canceling:

Screen.Recording.2021-10-14.at.3.52.44.PM.mov

michael-s-molina · 2021-10-14T20:41:59Z

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

github-actions · 2021-10-14T20:46:14Z

@michael-s-molina Ephemeral environment spinning up at http://34.212.76.74:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

jinghua-qa · 2021-10-15T02:40:07Z

Saw unexpected error when applying filters for different scope in multiple tabs.

Repo steps:
precondition: using video game sales dashboard
1, create value filter for platform and apply to tab 'overview'
2, create value filter for genre and apply to tab 'explore trends'
3, create time range filter and apply for all tabs
4,go to the dashboard and click on each tab to check filter scope
5, see unexpected error

Screen.Recording.2021-10-14.at.2.27.22.PM.mov

michael-s-molina · 2021-10-15T11:44:00Z

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

github-actions · 2021-10-15T11:48:04Z

@michael-s-molina Ephemeral environment spinning up at http://52.37.179.33:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

jinghua-qa

LGTM

michael-s-molina

LGTM. Thank you so much @m-ajay for your hard work and for addressing all the comments. This feature really benefits the user experience and it's a nice addition to the product. 👏🏼 🚀

graceguo-supercat · 2021-10-15T23:43:25Z

@michael-s-molina @jinghua-qa thanks for the hard work!!

github-actions · 2021-10-15T23:56:54Z

Ephemeral environment shutdown and build artifacts deleted.

* feat. flag: ON * refactor filter tabs * WIP * Drag and Rearrange, styling * refactoring dnd code * Add apache license header * Fix bug reported during PR review * Minor fix on remove * turn off filters * Fix status * Fix a test * Address PR comments * iSort fixes * Add type key to the new filters * Fix wrong attribute * indent * PR comments * PR comments * Fix failing tests * Styling * Fix remove filter * Fix the drag issue * Save works * fix * Write tests * Style changes * New Icon * Grab & Grabbing Cursor * Commented out code * Fix tests, fix CI * Fix failing tests * Fix test * Style fixes * portal nodes dependency * More style fixes * PR comments * add unique ids to collapse panels * Filter removal bug fixed * PR comments * Fix test warnings * delete filter tabs * Fix the breaking test * Fix warnings * Fix the weird bug on cancel * refactor * Fix broken scope

m-ajay added 7 commits July 22, 2021 16:56

feat. flag: ON

ed138e2

Merge branch 'master' into feat/native-filter-rearrage

84b8de1

Merge branch 'master' of https://github.com/apache/superset into feat…

684d8c1

…/native-filter-rearrage

refactor filter tabs

1e6cb2f

WIP

8b0982a

Drag and Rearrange, styling

a0cdd6b

refactoring dnd code

f74c57f

pull-request-size bot added the size/L label Aug 9, 2021

villebro requested review from michael-s-molina, kgabryje and zhaoyongjie August 9, 2021 21:03

junlincc added the need:qa-review Requires QA review label Aug 9, 2021

junlincc requested review from villebro, simcha90 and michael-s-molina and removed request for zhaoyongjie, kgabryje and michael-s-molina August 9, 2021 22:21

junlincc added the hold:testing! On hold for testing label Aug 10, 2021

m-ajay added 3 commits August 10, 2021 10:06

Add apache license header

7e988e3

Fix bug reported during PR review

077e081

Minor fix on remove

2d2fa28

m-ajay added 3 commits August 11, 2021 10:23

turn off filters

4e5d00b

Fix status

ec1559c

Merge branch 'master' into feat/native-filter-rearrage

2967992

m-ajay requested a review from michael-s-molina October 12, 2021 17:15

m-ajay added 3 commits October 13, 2021 05:54

merge conflicts - error alert is not working

09ac811

delete filter tabs

0f832a0

Fix the breaking test

2b81f94

michael-s-molina reviewed Oct 14, 2021

View reviewed changes

...ashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx Outdated Show resolved Hide resolved

Fix warnings

fce3de1

m-ajay requested review from michael-s-molina and graceguo-supercat October 14, 2021 17:32

m-ajay added 2 commits October 14, 2021 15:36

Fix the weird bug on cancel

839cc77

refactor

5f83b7c

Fix broken scope

06bf6eb

jinghua-qa approved these changes Oct 15, 2021

View reviewed changes

michael-s-molina approved these changes Oct 15, 2021

View reviewed changes

graceguo-supercat merged commit 9e6d5fc into apache:master Oct 15, 2021

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dashboard): Let users re-arrange native filters #16154

feat(dashboard): Let users re-arrange native filters #16154

m-ajay commented Aug 9, 2021

codecov bot commented Aug 9, 2021 •

edited

junlincc commented Aug 9, 2021

github-actions bot commented Aug 9, 2021

jinghua-qa commented Aug 9, 2021

m-ajay commented Aug 10, 2021

rusackas commented Oct 13, 2021

github-actions bot commented Oct 13, 2021

graceguo-supercat commented Oct 13, 2021

michael-s-molina commented Oct 14, 2021

github-actions bot commented Oct 14, 2021

michael-s-molina commented Oct 14, 2021

michael-s-molina commented Oct 14, 2021

github-actions bot commented Oct 14, 2021

jinghua-qa commented Oct 15, 2021

michael-s-molina commented Oct 15, 2021

github-actions bot commented Oct 15, 2021

jinghua-qa left a comment

michael-s-molina left a comment

graceguo-supercat commented Oct 15, 2021

github-actions bot commented Oct 15, 2021

feat(dashboard): Let users re-arrange native filters #16154

feat(dashboard): Let users re-arrange native filters #16154

Conversation

m-ajay commented Aug 9, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Aug 9, 2021 • edited

Codecov Report

junlincc commented Aug 9, 2021

github-actions bot commented Aug 9, 2021

jinghua-qa commented Aug 9, 2021

m-ajay commented Aug 10, 2021

rusackas commented Oct 13, 2021

github-actions bot commented Oct 13, 2021

graceguo-supercat commented Oct 13, 2021

michael-s-molina commented Oct 14, 2021

github-actions bot commented Oct 14, 2021

michael-s-molina commented Oct 14, 2021

michael-s-molina commented Oct 14, 2021

github-actions bot commented Oct 14, 2021

jinghua-qa commented Oct 15, 2021

michael-s-molina commented Oct 15, 2021

github-actions bot commented Oct 15, 2021

jinghua-qa left a comment

Choose a reason for hiding this comment

michael-s-molina left a comment

Choose a reason for hiding this comment

graceguo-supercat commented Oct 15, 2021

github-actions bot commented Oct 15, 2021

codecov bot commented Aug 9, 2021 •

edited