Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React dependency disallowed by Apache #3148

Closed
3 tasks done
robert-digit opened this issue Jul 17, 2017 · 5 comments
Closed
3 tasks done

React dependency disallowed by Apache #3148

robert-digit opened this issue Jul 17, 2017 · 5 comments

Comments

@robert-digit
Copy link
Contributor

robert-digit commented Jul 17, 2017

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

As per https://issues.apache.org/jira/browse/LEGAL-319
(more discussion at https://issues.apache.org/jira/browse/LEGAL-303 and https://news.ycombinator.com/item?id=14779881) - our use of React appears to violate Apache rules. We should consider another toolset if possible.

Superset version

All

Expected results

We are unencumbered by software patents

Actual results

We are encumbered by software patents, as prohibited by the Apache foundation

Steps to reproduce

N/A

@xrmx
Copy link
Contributor

xrmx commented Jul 17, 2017

The interesting issue is this facebook/react#10191, last update facebook/react#10191 (comment)

@robert-digit
Copy link
Contributor Author

Not a lot happening on this but it looks like we have two options:

  • Don't be associated with Apache
  • Don't use React.

Is there a better venue for this than a github issue? Seems like it merits discussion. This might actually be a decent chance to pare things down, using flask and appbuilder and node and React makes it hard to get started on development.

@busbey
Copy link

busbey commented Jul 30, 2017

Is there a better venue for this than a github issue? Seems like it merits discussion. This might actually be a decent chance to pare things down, using flask and appbuilder and node and React makes it hard to get started on development.

your project dev list would be the traditional place for these kinds of discussions. There's no reason it can't be on a github issue like this one, if it works for the community.

@mistercrunch
Copy link
Member

We're absolutely not ripping React out of this project, and PReact is not a viable option. So that leaves:

  • FB does the right thing and issues a clean BSD license in a timely fashion
  • We move this project out of the ASF and into another foundation (Cloud Native perhaps?) that is fine with React
  • Move the IP back to Airbnb?

We should have the conversation on the mailing list. In the meantime I'm keeping an eye on facebook/react#10191 and hoping for the best

@xrmx
Copy link
Contributor

xrmx commented Sep 26, 2017

React 16 is out under MIT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants