[Dashboard][Slug] Spaces and hyphens are being ignored.

[NaukhaizAhmad]

Superset version

0.20.3

Expected results

• Spaces should be replaced by hyphens or underscores.
• Hyphens shouldn't be ignored.

Actual results

Spaces and hyphens are being ignored.

Steps to reproduce

open the dashboard configuration GUI
add slug with spaces and hyphens
save the dashboard configurations.
Re-open the dashboard configurations again to review the previously saved state
the Spaces and hyphens would be missing from the slug.

P.S. All special characters are also being ignored (except underscore _).

[xrmx]

That's exactly the purpose of the slug https://en.wikipedia.org/wiki/Semantic_URL#Slug

[rumbin]

Well, I don't fully agree with @xrmx. In the link provided it is clearly stated whitespace characters [are] replaced by a dash or an underscore to avoid being encoded. So the hyphens/dashes being dropped and the white spaces not being replaced by dashes or underscores may be regarded as unexpected behavior.

[xrmx]

Yeah the implementation of this slug is buggy (\W+ in the re.sub matches -) but unless anyone cares enough to open a PR that's not really an issue.

[TryHarder01]

It sounds like the "expected results" aren't exactly on point.

The expected result is that spaces are replaced, but dashes and hyphens stays.

[rumbin]

The awesome-slugify package seems to do the job quite simply.

[NaukhaizAhmad]

I second @rumbin comments about the link shared by @xrmx .
1- Spaces has to be replaced with dashes or underscores.
2- Dropping the hyphens/dashes is not the intended behavior.