Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL Lab] autocomplete table names, auto-add to schema browser #7059

Closed
mistercrunch opened this issue Mar 19, 2019 · 2 comments
Closed

[SQL Lab] autocomplete table names, auto-add to schema browser #7059

mistercrunch opened this issue Mar 19, 2019 · 2 comments
Labels
enhancement:request Enhancement request submitted by anyone from the community good first issue Good first issues for new contributors inactive Inactive for >= 30 days sqllab Namespace | Anything related to the SQL Lab

Comments

@mistercrunch
Copy link
Member

Currently, autocomplete in SQL Lab's editor is limited to table and column names that have been added to the schema browser.

To that, we should add autocomplete for:

  • schema names
  • table names that are in the active database / schema

On the event of using a table name from autocomplete, we should add this new table to the schema browser for reference. From that point the column names from that added table should become "auto-completable"
@mistercrunch mistercrunch added sqllab Namespace | Anything related to the SQL Lab starter-task labels Mar 19, 2019
@enricoberti
Copy link
Contributor

Working on it

@enricoberti enricoberti mentioned this issue Mar 26, 2019
Closed
@kristw kristw added the enhancement:request Enhancement request submitted by anyone from the community label Mar 27, 2019
enricoberti added a commit to enricoberti/incubator-superset that referenced this issue Apr 1, 2019
@enricoberti
[SQL Lab] Adds autocomplete on table names and auto-add to schema bro…
c303eb8 
…wser

Closes apache#7059
@stale
Copy link

stale bot commented May 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label May 27, 2019
@mistercrunch mistercrunch added the good first issue Good first issues for new contributors label Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement:request Enhancement request submitted by anyone from the community good first issue Good first issues for new contributors inactive Inactive for >= 30 days sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Milestone
No milestone
3 participants
@mistercrunch @enricoberti @kristw