Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useless-self-assignment): correct useless-self-assignment #7090

Merged
merged 2 commits into from
Mar 26, 2019

Conversation

rasmi-ranjan-guavus
Copy link
Contributor

#bug Remove or correct this useless self-assignment.

Superset version

0.29

@codecov-io
Copy link

Codecov Report

Merging #7090 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7090      +/-   ##
==========================================
+ Coverage   64.46%   64.59%   +0.13%     
==========================================
  Files         422      422              
  Lines       20566    20586      +20     
  Branches     2250     2251       +1     
==========================================
+ Hits        13257    13297      +40     
+ Misses       7182     7167      -15     
+ Partials      127      122       -5
Impacted Files Coverage Δ
superset/views/utils.py 92.85% <100%> (-0.25%) ⬇️
...et/assets/src/dashboard/reducers/dashboardState.js 91.66% <0%> (-2.62%) ⬇️
...src/dashboard/components/HeaderActionsDropdown.jsx 67.44% <0%> (-2.56%) ⬇️
superset/models/core.py 83.56% <0%> (-0.06%) ⬇️
...t/assets/src/dashboard/reducers/getInitialState.js 0% <0%> (ø) ⬆️
...ssets/src/dashboard/containers/DashboardHeader.jsx 100% <0%> (ø) ⬆️
...rset/assets/src/dashboard/components/SaveModal.jsx 46.15% <0%> (ø) ⬆️
superset/common/query_object.py 26.31% <0%> (ø) ⬆️
superset/viz.py 71.53% <0%> (ø) ⬆️
superset/views/core.py 74.92% <0%> (+0.01%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4631b7b...a01188d. Read the comment docs.

@mistercrunch mistercrunch merged commit f556da8 into apache:master Mar 26, 2019
@rasmi-ranjan-guavus rasmi-ranjan-guavus deleted the fix/useless-self-assignment branch March 26, 2019 16:27
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants