[SQL Lab] Moved from React.PureComponent to React.Component

[enricoberti]

It also fixes an overlap between the results status label and the progress bar

It could solve/improve #6527

[codecov-io]

Codecov Report

Merging #7092 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7092   +/-   ##
=======================================
  Coverage   64.46%   64.46%           
=======================================
  Files         422      422           
  Lines       20566    20566           
  Branches     2250     2250           
=======================================
  Hits        13257    13257           
  Misses       7182     7182           
  Partials      127      127

Impacted Files	Coverage Δ
superset/assets/src/SqlLab/components/Link.jsx	81.81% <ø> (ø)	⬆️
...erset/assets/src/SqlLab/components/QuerySearch.jsx	58.65% <ø> (ø)	⬆️
...rset/assets/src/SqlLab/components/LimitControl.jsx	91.17% <ø> (ø)	⬆️
superset/assets/src/SqlLab/components/App.jsx	80.55% <ø> (ø)	⬆️
...uperset/assets/src/SqlLab/components/ResultSet.jsx	80% <ø> (ø)	⬆️
.../assets/src/SqlLab/components/AceEditorWrapper.jsx	56.92% <ø> (ø)	⬆️
.../assets/src/SqlLab/components/QueryAutoRefresh.jsx	12.82% <ø> (ø)	⬆️
...ets/src/SqlLab/components/ExploreResultsButton.jsx	72% <ø> (ø)	⬆️
...t/assets/src/SqlLab/components/QueryStateLabel.jsx	100% <ø> (ø)	⬆️
...uperset/assets/src/SqlLab/components/SqlEditor.jsx	57.44% <ø> (ø)	⬆️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4631b7b...c1360c5. Read the comment docs.

[kristw]

Could you explain a bit why the PureComponent become an issue here?
Also, this PR changes multiple files. Do they all need to be Component and unable to take advantage of the PureComponent?

[enricoberti]

@kristw this is actually a WIP to try to fix a flaky behavior at Lyft - we cannot reproduce it constantly and it could be related to something in the redux store that mutates when it shouldn't. I've asked @xtinec to try it out internally and see if the situation improves. Please hold on with merging, thanks!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.