Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Box isue on pt_BR language #7134

Closed
3 tasks done
lucasapaixao opened this issue Mar 26, 2019 · 2 comments
Closed
3 tasks done

Filter Box isue on pt_BR language #7134

lucasapaixao opened this issue Mar 26, 2019 · 2 comments
Labels
i18n Namespace | Anything related to localization

Comments

@lucasapaixao
Copy link

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Superset version

0.28.1

Expected results

A translation of filterbox chart

Actual results

When you apply the pt_BR translation in the Filter Box Chart, it crash with the following message:

PS: In English language does not occur the error

SyntaxError: [sprintf] unexpected placeholder
at http://10.18.200.102/static/assets/dist/explore.d3beaf73a661104a3627.entry.js:2:812937
at a (http://10.18.200.102/static/assets/dist/explore.d3beaf73a661104a3627.entry.js:2:813517)
at c (http://10.18.200.102/static/assets/dist/explore.d3beaf73a661104a3627.entry.js:2:64486)
at f (http://10.18.200.102/static/assets/dist/explore.d3beaf73a661104a3627.entry.js:2:64798)
at http://10.18.200.102/static/assets/dist/filter_box.885b5b9fd31f4d3caa48.chunk.js:2:365206
at Array.map ()
at t. (http://10.18.200.102/static/assets/dist/filter_box.885b5b9fd31f4d3caa48.chunk.js:2:364863)
at t. (http://10.18.200.102/static/assets/dist/filter_box.885b5b9fd31f4d3caa48.chunk.js:2:365985)
at Qi (http://10.18.200.102/static/assets/dist/vendors-major.4f5a17619ab655ae0e0c.chunk.js:2:1384797)
at Xi (http://10.18.200.102/static/assets/dist/vendors-major.4f5a17619ab655ae0e0c.chunk.js:2:1384639)

filterbox

filterbox-2

Steps to reproduce

  1. Use the EN transalate and create a Filter Box chart
  2. Modify the language to pt_BR(Brazilian Portuguese) and the Filter Box will crach.

Ps: Sorry for any translation error.

@mistercrunch mistercrunch added help-wanted i18n Namespace | Anything related to localization labels Mar 27, 2019
@lucasapaixao
Copy link
Author

I found several invalid entries in files messages.json and messages.po, basicly i searched for string % s(with a space between the caracthers) and repacle for %s.
After the change i runned "pybabel compile -d translations" in superset folder and restart the daemon.

Reference for solution: 9044629

@mistercrunch
Copy link
Member

Just a thought, we should have some sort of continuous integration validating these .po files...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Namespace | Anything related to localization
Projects
None yet
Development

No branches or pull requests

2 participants