Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condition in WorldMapViz before using Pandas' iloc #7156

Closed
wants to merge 0 commits into from

Conversation

elukey
Copy link
Contributor

@elukey elukey commented Mar 28, 2019

Recent pandas versions (0.23+) changed the value of df[metric]
when the same metric is used in a World Map panel for both bubble size
and an axis (either X or Y). This change adds some guards before
using panda's iloc to avoid exceptions.

Should fix #7006

@codecov-io
Copy link

codecov-io commented Mar 29, 2019

Codecov Report

Merging #7156 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7156      +/-   ##
==========================================
- Coverage   64.63%   64.63%   -0.01%     
==========================================
  Files         422      422              
  Lines       20607    20609       +2     
  Branches     2253     2253              
==========================================
  Hits        13320    13320              
- Misses       7165     7167       +2     
  Partials      122      122
Impacted Files Coverage Δ
superset/viz.py 71.44% <0%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e79e84...3231a03. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

World map viz not working in 0.29rc7/0.31.0rc18/0.32
2 participants