Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in translations placeholders #7161

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Conversation

leakingoxide
Copy link
Contributor

This is a PR for #7134.

I'm not entirely sure this fixes the problem that was described, because I wasn't able to get the error shown on the screen, but had to check JS console instead. Nevertheless, I'm pretty sure these typos should be corrected.

Also, I'm not sure if the .mo files should be included in the PR as well?

@codecov-io
Copy link

codecov-io commented Mar 29, 2019

Codecov Report

Merging #7161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7161   +/-   ##
=======================================
  Coverage   64.63%   64.63%           
=======================================
  Files         422      422           
  Lines       20607    20607           
  Branches     2253     2253           
=======================================
  Hits        13320    13320           
  Misses       7165     7165           
  Partials      122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a6fad...9044629. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #7161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7161   +/-   ##
=======================================
  Coverage   64.63%   64.63%           
=======================================
  Files         422      422           
  Lines       20607    20607           
  Branches     2253     2253           
=======================================
  Hits        13320    13320           
  Misses       7165     7165           
  Partials      122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a6fad...9044629. Read the comment docs.

@kristw kristw merged commit 07d9dbd into apache:master Apr 18, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants