Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] metadata editing modal generates invalid dashboard url #8968

Closed
graceguo-supercat opened this issue Jan 15, 2020 · 2 comments
Closed
Labels

Comments

@graceguo-supercat
Copy link
Contributor

@graceguo-supercat graceguo-supercat commented Jan 15, 2020

Related to #8876.

Expected results

Empty slug and save should work.

Actual results

wcP2m7fq5D

Environment

(please complete the following information):

  • superset version: latest master

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

cc @suddjian

@issue-label-bot issue-label-bot bot added the #bug label Jan 15, 2020
@issue-label-bot

This comment has been minimized.

Copy link

@issue-label-bot issue-label-bot bot commented Jan 15, 2020

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@suddjian

This comment has been minimized.

Copy link
Contributor

@suddjian suddjian commented Jan 15, 2020

😱thanks for catching!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.