Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [logging] fix render chart error type #10000

Merged

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Jun 5, 2020

SUMMARY

This PR is to fix a logging issue: remove an unnecessary user_event render_chart_container error type, and use render_chart for all chart render errors.

TEST PLAN

Manual test

@etr2460 @ktmud

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020

Codecov Report

Merging #10000 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10000   +/-   ##
=======================================
  Coverage   70.40%   70.41%           
=======================================
  Files         585      585           
  Lines       31043    31042    -1     
  Branches     3277     3277           
=======================================
  Hits        21857    21857           
+ Misses       9075     9074    -1     
  Partials      111      111           
Flag Coverage Δ
#cypress 53.93% <0.00%> (+<0.01%) ⬆️
#javascript 59.36% <0.00%> (-0.01%) ⬇️
#python 69.98% <ø> (ø)
Impacted Files Coverage Δ
superset-frontend/src/chart/Chart.jsx 66.66% <0.00%> (ø)
superset-frontend/src/logger/LogUtils.js 100.00% <ø> (ø)
.../src/dashboard/components/gridComponents/Chart.jsx 89.88% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e0188...10ab169. Read the comment docs.

@villebro
Copy link
Member

villebro commented Jun 5, 2020

Congrats @graceguo-supercat for opening PR number #10000 ! 🎉

@ktmud
Copy link
Member

ktmud commented Jun 5, 2020

🥳 🎆 🎉 🎉 🥳 🎆 🎉 🎉 🥳 🎆 🎉 🎉 🥳 🎆 🎉 🎉 🥳 🎆 🎉 🎉 🥳 🎆 🎉 🎉 🥳 🎆 🎉 🎉

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@graceguo-supercat graceguo-supercat merged commit 656cdfb into apache:master Jun 5, 2020
@graceguo-supercat graceguo-supercat deleted the gg-FixChartErrorType branch June 11, 2020 23:17
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants