Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky test_copy_dash test in dashboard_tests.py #10021

Merged
merged 1 commit into from Jun 9, 2020

Conversation

villebro
Copy link
Member

@villebro villebro commented Jun 9, 2020

SUMMARY

Fix a flaky unit test that was caused by the changed_on_humanized property in AuditMixinNullable: https://github.com/apache/incubator-superset/blob/315518d2d22a63de1b2e5f556e7fb5737669ebd6/superset/models/helpers.py#L383-L385

BEFORE

image

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2020

Codecov Report

Merging #10021 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10021      +/-   ##
==========================================
- Coverage   70.41%   70.37%   -0.05%     
==========================================
  Files         585      585              
  Lines       31056    31056              
  Branches     3277     3277              
==========================================
- Hits        21869    21856      -13     
- Misses       9076     9089      +13     
  Partials      111      111              
Flag Coverage Δ
#cypress 53.93% <ø> (ø)
#javascript 59.36% <ø> (ø)
#python 69.92% <ø> (-0.08%) ⬇️
Impacted Files Coverage Δ
superset/db_engine_specs/mysql.py 78.26% <0.00%> (-13.05%) ⬇️
superset/models/core.py 85.42% <0.00%> (-0.88%) ⬇️
superset/views/core.py 76.06% <0.00%> (-0.22%) ⬇️
superset/connectors/sqla/models.py 88.80% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315518d...8638c47. Read the comment docs.

@villebro villebro merged commit 526ee3c into apache:master Jun 9, 2020
@villebro villebro deleted the villebro/fix-test-copy-dash branch June 9, 2020 10:29
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants