feat: Add owners and physical/virtual status to Datasets API list endpoint #10025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10025 +/- ##
==========================================
+ Coverage 70.41% 70.47% +0.06%
==========================================
Files 585 583 -2
Lines 31058 31028 -30
Branches 3267 3175 -92
==========================================
- Hits 21868 21866 -2
+ Misses 9079 9053 -26
+ Partials 111 109 -2
Continue to review full report at Codecov.
|
villebro
requested changes
Jun 10, 2020
There was a problem hiding this comment.
Small nit, otherwise LGTM. However, I wonder if we could come up with a more descriptive suffix than "kind". Not sure what it would be, and the obvious alternatives (type, class etc) are no more descriptive than this, but if something comes to mind it might be worth exploring.
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
willbarrett
force-pushed
the
wbarrett/add-less-to-datasets-list
branch
from
69e08c8
to
69e7dc8
Compare
willbarrett
force-pushed
the
wbarrett/add-less-to-datasets-list
branch
from
69e7dc8
to
41cacfa
Compare
|
Sorry for the force-pushes. It's just the same commit with a different description to try to get a clean build. Running into flakes. |
villebro
approved these changes
Jun 10, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
…point (apache#10025) * Add owners and physical/virtual status to Datasets API list endpoint * black * Update type definition for DatasourceKind Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> * Fixin' tests and mypy Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In #9959 we ran into issues with joins from FAB, and while we are working on a fix for both that bug and adding the option to specify a base query, those will not be ready immediately. This PR adds the un-blocked fields from the previous PR to the datasets list API endpoint for consumption in an updated Datasets UI.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See #9959
TEST PLAN
See #9959
ADDITIONAL INFORMATION
Reviewers
@dpgaspar @nytai @mistercrunch