fix: native annotations #10037
Merged
fix: native annotations #10037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10037 +/- ##
==========================================
- Coverage 68.91% 68.85% -0.06%
==========================================
Files 584 584
Lines 31047 31056 +9
Branches 3180 3180
==========================================
- Hits 21395 21384 -11
- Misses 9543 9563 +20
Partials 109 109
Continue to review full report at Codecov.
|
|
I propose merging this as-is, and adding more comprehensive tests later if we refactor annotations (I hadn't worked extensively with the annotation code before, but it seems to be in need of some refactoring at some point). |
villebro
commented
Jun 11, 2020
| @@ -103,7 +103,7 @@ class AnnotationLayerModelView(SupersetModelView): # pylint: disable=too-many-a | |||
| add_title = _("Add Annotation Layer") | |||
| edit_title = _("Edit Annotation Layer") | |||
|
|
|||
| list_columns = ["name", "descr"] | |||
| list_columns = ["id", "name", "descr"] | |||
There was a problem hiding this comment.
This will make the CRUD view slightly uglier with the id, but is necessary based on discussions with @dpgaspar
dpgaspar
approved these changes
Jun 11, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* fix: native annotations * Add test * Add comment to test
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Native annotations are currently broken due to regressions in recent PRs:
BEFORE
Bug number 1: RLS breaks annotations as they only apply to SQL datasources if
ENABLE_ROW_LEVEL_SECURITYis enabled:Bug number 2: The
idof the annotation layer was dropped in #9888 , hence can't be selected:AFTER
TEST PLAN
Local testing + new test + CI
ADDITIONAL INFORMATION