Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [logging] add dashboard is_published into perf logging #10042

Merged

Conversation

graceguo-supercat
Copy link

SUMMARY

add dashboard is_published status into dashboard perf logging.

TEST PLAN

CI and manul test

@etr2460

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #10042 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10042      +/-   ##
==========================================
+ Coverage   68.88%   68.90%   +0.02%     
==========================================
  Files         584      584              
  Lines       31058    31045      -13     
  Branches     3180     3180              
==========================================
  Hits        21393    21393              
+ Misses       9555     9542      -13     
  Partials      110      110              
Flag Coverage Δ
#cypress 53.99% <ø> (+0.16%) ⬆️
#javascript 59.48% <ø> (ø)
#python 67.35% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
...et-frontend/src/dashboard/components/Dashboard.jsx 84.33% <ø> (ø)
.../src/dashboard/components/gridComponents/Chart.jsx 88.76% <0.00%> (-1.13%) ⬇️
superset/views/dashboard/filters.py 95.23% <0.00%> (-0.22%) ⬇️
superset/dashboards/filters.py 96.55% <0.00%> (-0.12%) ⬇️
superset/security/manager.py 89.04% <0.00%> (-0.08%) ⬇️
superset/sql_parse.py 99.28% <0.00%> (-0.01%) ⬇️
superset/errors.py 100.00% <0.00%> (ø)
superset/viz_sip38.py 0.00% <0.00%> (ø)
superset/views/core.py 75.39% <0.00%> (ø)
superset/views/database/forms.py 90.69% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c6ddb...4c39d3a. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit 0724edd into apache:master Jun 12, 2020
@graceguo-supercat graceguo-supercat deleted the gg-AddPublishStatusToLog branch November 11, 2020 23:18
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants