Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumping superset-ui theme version #10059

Merged

Conversation

rusackas
Copy link
Member

SUMMARY

Opens up access to colors for Emotion-based styling

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #10059 into master will increase coverage by 4.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10059      +/-   ##
==========================================
+ Coverage   65.68%   70.50%   +4.81%     
==========================================
  Files         585      585              
  Lines       31074    31089      +15     
  Branches     3185     3185              
==========================================
+ Hits        20412    21920    +1508     
+ Misses      10484     9060    -1424     
+ Partials      178      109      -69     
Flag Coverage Δ
#cypress 53.91% <ø> (?)
#javascript 59.49% <ø> (ø)
#python 70.09% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
superset/errors.py 100.00% <0.00%> (ø)
superset/viz_sip38.py 0.00% <0.00%> (ø)
superset/sql_parse.py 99.29% <0.00%> (+<0.01%) ⬆️
superset/viz.py 57.18% <0.00%> (+0.02%) ⬆️
superset/db_engine_specs/base.py 86.95% <0.00%> (+0.03%) ⬆️
superset/views/base.py 73.59% <0.00%> (+0.11%) ⬆️
...rontend/src/SqlLab/components/AceEditorWrapper.tsx 56.98% <0.00%> (+1.07%) ⬆️
superset-frontend/src/components/EditableTitle.jsx 81.69% <0.00%> (+1.40%) ⬆️
...perset-frontend/src/components/CopyToClipboard.jsx 36.36% <0.00%> (+1.51%) ⬆️
...hboard/components/resizable/ResizableContainer.jsx 71.87% <0.00%> (+1.56%) ⬆️
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98ab95e...a55c313. Read the comment docs.

@mistercrunch
Copy link
Member

What's pullapprove?

@rusackas
Copy link
Member Author

What's pullapprove?

¯\_(ツ)_/¯ I don't know, but it seems unhappy.

@rusackas rusackas closed this Jun 16, 2020
@rusackas rusackas reopened this Jun 16, 2020
@rusackas rusackas merged commit 00e6d7d into apache:master Jun 16, 2020
@rusackas rusackas deleted the chore-bumping-superset-theme-package branch June 16, 2020 23:33
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants